Conversation

Notices

1. Eugen (gargron@mastodon.social)'s status on Monday, 01-Oct-2018 06:37:20 JST Eugen

   • Snake Girl Ellie

   @noelle I updated today. What do you mean distress? People were begging me for it for a very long time.

   • Eugen (gargron@mastodon.social)'s status on Monday, 01-Oct-2018 06:40:40 JST Eugen

     • Snake Girl Ellie
     • Nate Cull

     @noelle @natecull It's pixel-height based, not characters (it's very difficult to do it based on character count) and calibrated to cut off after 500 characters (but paragraphs are not taken into account, so if it was a single block of text)

   • Eugen (gargron@mastodon.social)'s status on Monday, 01-Oct-2018 06:45:49 JST Eugen

     in reply to

     • Snake Girl Ellie
     • Nate Cull

     @noelle @natecull I was against this since the start (see https://github.com/tootsuite/mastodon/pull/658) which actually gave start to the glitch-soc fork in the first place iirc

     But people kept asking for it, e.g. https://github.com/tootsuite/mastodon/issues/7973 and https://github.com/tootsuite/mastodon/issues/255

     And when another person re-submitted it *again*, especially with constant pressure "why don't you merge this" "when will you merge this", I gave it a makeover to save you from the worst UX (see https://github.com/tootsuite/mastodon/pull/8205)

   • Eugen (gargron@mastodon.social)'s status on Monday, 01-Oct-2018 06:50:33 JST Eugen

     in reply to

     • Snake Girl Ellie
     • Nate Cull

     @noelle @natecull I'd love it if people could occassionally back me when I refuse features like that, so I don't feel like Hitler-vs-the-people. In this case I'm not a fan of "read more" at all but I like my version of it much more than what's in glitch-soc and what was proposed by the author of the patch.

     We could either drop the feature again if there is support for dropping it, or we could adjust when it kicks in a bit more.

   • Eugen (gargron@mastodon.social)'s status on Monday, 01-Oct-2018 06:57:30 JST Eugen

     • Snake Girl Ellie
     • Nate Cull

     @noelle @natecull Right. I'm frustrated because it's the people submitting those patches and putting the pressure on who should be learning this lesson, but they won't, because their responsibility ends after they submit the pull request.

     Sometimes I really wish there was just a way to stop people from submitting pull requests on GitHub unless they're on a whitelist.